Codecov Report

Merging #3231 (baf4528) into develop (66b29ec) will increase coverage by 0.10%.
Report is 1 commits behind head on develop.
The diff coverage is 41.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3231      +/-   ##
===========================================
+ Coverage    25.19%   25.30%   +0.10%     
===========================================
  Files           54       54              
  Lines        11933    11943      +10     
===========================================
+ Hits          3007     3022      +15     
+ Misses        8926     8921       -5     

... and 2 files with indirect coverage changes

@khassel

and do you think about change module position when MM² is running ?
some users ask to me this feature when whey use some "pages" 3rd party modules

sample using with an pages module

• page 1: weather in top_right // clock in top_left // ...
• page 2 : weather in top_left // clock in top_right // ...

Actually they have to use multi-instance of a module with hide // show feature

there is a module that does this now in 3rd party list

https://github.com/Toreke/MMM-Dynamic-Modules

I already forgot this PR ...

and do you think about change module position when MM² is running ?

not before your comment ...

This PR was only meant for discussing custom module positions, the implementation is a little ugly, not sure if this should go live ...

I think it would be nice if we could give the users more flexibility with this option. I might prefer a more elegant solution. But I can't think of one at the moment 😅

the problem is that I tell myself... I would have tried to code it but I'm recoding on one of my modules (and it's giving me a headache...)

When I've done it...why don't I start coding it. (this might be interesting)
We still have a lot of time ahead of us :p

Note: sometimes it would be good to have a TODO file :p

Note: sometimes it would be good to have a TODO file :p

I think we should do this with issues, there is already #3212 but I can create a new one for this feature (and assign it to you if you want).

I submitted #3518 which reads index.html to get the defined regions for this run

this is superceded by #3518